[
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251200#comment-16251200
]
Anoop Sam John commented on HBASE-19235:
----------------------------------------
If we have to avoid the instance of check while calling startup or shutdown, we
have to change
public abstract class CoprocessorHost<C extends Coprocessor, E extends
BaseEnvironment<C>>
Note BaseEnvironment instead of CoprocessorEnvironment.
Subsequently we will have to make changes in all CPHost impls. Now we have
RegionServerCoprocessorHost extends CoprocessorHost<RegionServerCoprocessor,
RegionServerCoprocessorEnvironment>
RegionCoprocessorHost extends CoprocessorHost<RegionCoprocessor,
RegionCoprocessorEnvironment>
Like these.
I feel all these changes will be much more ugly than having an instance of
check. Infact we need all our internal impls of the CPEnv to be extending
BaseEnv. So we can even have just an assert and type casting way.. In future
any one make a new impl of CPEnv not extending BaseEnv, this will break any way.
> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Affects Versions: 2.0.0-alpha-4
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with
> LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions
> in this are. Better we mark CoprocessorEnvironment also as CP exposed to
> avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
