[
https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384217#comment-16384217
]
Hadoop QA commented on HBASE-19985:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} HBASE-19985 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19985 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912831/HBASE-19985.v01.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11785/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Redundant instanceof check in ProtobufUtil#getServiceException
> --------------------------------------------------------------
>
> Key: HBASE-19985
> URL: https://issues.apache.org/jira/browse/HBASE-19985
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.4.1
> Reporter: Ted Yu
> Assignee: Artem Ervits
> Priority: Trivial
> Fix For: 1.5.0, 1.4.3
>
> Attachments: HBASE-19985.v01.patch
>
>
> {code}
> public static IOException getServiceException(ServiceException e) {
> Throwable t = e;
> if (e instanceof ServiceException) {
> t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by
> https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
