[ 
https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385035#comment-16385035
 ] 

Hudson commented on HBASE-19985:
--------------------------------

Results for branch branch-1, done in 2 hr 7 min and counting
        [build #238 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/238/]:
----
details (if available):

(x) *{color:red}-1 overall{color}*
    Committer, please check your recent inclusion of a patch for this issue.









(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Redundant instanceof check in ProtobufUtil#getServiceException
> --------------------------------------------------------------
>
>                 Key: HBASE-19985
>                 URL: https://issues.apache.org/jira/browse/HBASE-19985
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Ted Yu
>            Assignee: Artem Ervits
>            Priority: Trivial
>             Fix For: 1.5.0, 1.4.3
>
>         Attachments: HBASE-19985.branch-1.v01.patch, HBASE-19985.v01.patch
>
>
> {code}
>   public static IOException getServiceException(ServiceException e) {
>     Throwable t = e;
>     if (e instanceof ServiceException) {
>       t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by 
> https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to