[
https://issues.apache.org/jira/browse/HBASE-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384696#comment-16384696
]
Appy commented on HBASE-19985:
------------------------------
Sorry for late reply, was traveling in a 15hr flight.
I'd recommend using {{dev-support/submit-patch.py}} tool instead, since it also
does the work of uploading the patch to Jira and creating review board (unless
specified not to). Have a look at it's help (--help).
That tool will need that base branch is set for the current branch, so run
{{git branch --set-upstream-to=apache/branch-1.4}} before running the tool,
then it should work.
If you have any further issues, please let me know, happy to help.
> Redundant instanceof check in ProtobufUtil#getServiceException
> --------------------------------------------------------------
>
> Key: HBASE-19985
> URL: https://issues.apache.org/jira/browse/HBASE-19985
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.4.1
> Reporter: Ted Yu
> Assignee: Artem Ervits
> Priority: Trivial
> Fix For: 1.5.0, 1.4.3
>
> Attachments: HBASE-19985.branch-1.v01.patch, HBASE-19985.v01.patch
>
>
> {code}
> public static IOException getServiceException(ServiceException e) {
> Throwable t = e;
> if (e instanceof ServiceException) {
> t = e.getCause();
> {code}
> The instanceof check would always return true.
> This was reported by
> https://builds.apache.org/job/PreCommit-HBASE-Build/11495/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html#Warnings_STYLE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
