[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205139#comment-13205139
]
stack commented on HBASE-5325:
------------------------------
Ok. I can go along w/ cutting the scope of this issue back to its original
intent (smile -- sorry for the hairbraining).
I was going to make a comment that we have the jmx 'model' not be a completely
new one -- that it instead pick the existing model (though admittedly its a bit
messy) -- but it looks like your hand has been forced some already. I was
going to suggest that we name the mbean for metrics MasterMetrics rather than
MasterStatistics but I see this an existing MBean (Who named our mbean 'Master'
and 'MasterStatistics' -- our history doesn't say... they don't seem like good
names... why not org.apache.hbase prefix... etc.)
Why is HBaseMasterMXBean in hbase.metrics and not in hbase.master.metrics?
Ditto HbaseRegionServerMXBean
You don't need these in your new files:
+ * Copyright 2012 The Apache Software Foundation
Why not name the bean for the master servername especially as there can be
multiple masters running in a cluster -- getServerName.
Why would you have this info in regionserver jmx attributes:
+ public String getHBaseMaster();
This is pretty useless:
+ public long getStartCode();
Better return the regionserver ServerName. Or name the mbean for the
ServerName.
More to follow...
> Expose basic information about the master-status through jmx beans
> -------------------------------------------------------------------
>
> Key: HBASE-5325
> URL: https://issues.apache.org/jira/browse/HBASE-5325
> Project: HBase
> Issue Type: Improvement
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5325.1.patch, HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master
> could expose some information through mbeans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
