[ 
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Shah updated HBASE-5325:
-------------------------------

    Attachment: HBASE-5325.2.patch

Most review comments addressed. 

Change class names to more appropriate ones. Changed the impl classes to have 
an Impl suffix instead of a different Info based name. 

@Stack - the only major thing unchanged is the retention of the use of the 
HRegionServer  for the RS bean as its required for the master address info. 
Using the interfaces suggested would have most other aspects but finding out 
the master required the master address tracker which is only available in the 
HRegionServer class. 

The other thing for the RegionServer bean is that it is still pretty limited in 
terms of information being exposed. I am welcome to suggestions to what else 
could be included in the bean without it blurring the lines between the simple 
info and metrics. 

Sample jmx output: 

{code}
{
    "name" : "hadoop:service=org.apache.hadoop.hbase,name=Master",
    "modelerType" : "org.apache.hadoop.hbase.master.MasterMXBeanImpl",
    "ClusterId" : "d24914d7-75d3-4dcc-9e6f-0d7770833993",
    "MasterStartTime" : 1329097289084,
    "MasterActiveTime" : 1329097289088,
    "Coprocessors" : [ ],
    "ServerName" : "unknowne4ce8f149fb6,57608,1329097288776",
    "AverageLoad" : 2.0,
    "RegionsInTransition" : [ ],
    "RegionServers" : [ {
      "key" : "unknowne4ce8f149fb6,57610,1329097289066",
      "value" : {
        "coprocessors" : [ ],
        "load" : 2,
        "maxHeapMB" : 987,
        "memStoreSizeInMB" : 0,
        "numberOfRegions" : 2,
        "numberOfRequests" : 0,
        "regionsLoad" : [ {
          "key" : [ 46, 77, 69, 84, 65, 46, 44, 44, 49 ],
          "value" : {
            "currentCompactedKVs" : 0,
            "memStoreSizeMB" : 0,
            "name" : [ 46, 77, 69, 84, 65, 46, 44, 44, 49 ],
            "nameAsString" : ".META.,,1",
            "readRequestsCount" : 8,
            "requestsCount" : 8,
            "storefileIndexSizeMB" : 0,
            "storefileSizeMB" : 0,
            "storefiles" : 0,
            "stores" : 1,
            "totalCompactingKVs" : 0,
            "version" : 2,
            "writeRequestsCount" : 0
          }
        }, {
          "key" : [ 45, 82, 79, 79, 84, 45, 44, 44, 48 ],
          "value" : {
            "currentCompactedKVs" : 0,
            "memStoreSizeMB" : 0,
            "name" : [ 45, 82, 79, 79, 84, 45, 44, 44, 48 ],
            "nameAsString" : "-ROOT-,,0",
            "readRequestsCount" : 16,
            "requestsCount" : 17,
            "storefileIndexSizeMB" : 0,
            "storefileSizeMB" : 0,
            "storefiles" : 3,
            "stores" : 1,
            "totalCompactingKVs" : 0,
            "version" : 2,
            "writeRequestsCount" : 1
          }
        } ],
        "storefileIndexSizeInMB" : 0,
        "storefileSizeInMB" : 0,
        "storefiles" : 3,
        "totalNumberOfRequests" : 0,
        "usedHeapMB" : 31,
        "version" : 2
      }
    } ],
    "ZookeeperQuorum" : "localhost:2181",
    "DeadRegionServers" : [ ]
  }

{
    "name" : "hadoop:service=org.apache.hadoop.hbase,name=RegionServer",
    "modelerType" : "org.apache.hadoop.hbase.regionserver.ServerMXBeanImpl",
    "Coprocessors" : [ ],
    "ServerName" : "unknowne4ce8f149fb6,57610,1329097289066",
    "HBaseMaster" : "unknowne4ce8f149fb6:60010"
  }

{code}




                
> Expose basic information about the master-status through jmx beans 
> -------------------------------------------------------------------
>
>                 Key: HBASE-5325
>                 URL: https://issues.apache.org/jira/browse/HBASE-5325
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5325.1.patch, HBASE-5325.2.patch, 
> HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master 
> could expose some information through mbeans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to