ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324264609
########## File path: dev-support/docker/Dockerfile ########## @@ -97,9 +94,7 @@ RUN apt-get -q install --no-install-recommends -y zulu-8 zulu-7 RUN update-alternatives --config java RUN update-alternatives --config javac RUN mv /usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/moved.java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-7-amd64 /usr/lib/jvm/java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-8-amd64 /usr/lib/jvm/java-8-openjdk-amd64 - +ENV JAVA_HOME /usr/lib/jvm/zulu-7-amd64 Review comment: Rather than manage the variable in Docker, why not pass it in as `--java-home` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
