ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324266066
########## File path: dev-support/hbase_nightly_yetus.sh ########## @@ -40,6 +40,10 @@ if [[ -n "${MULTIJDK}" ]]; then YETUS_ARGS=("--multijdkdirs=${MULTIJDK}" "${YETUS_ARGS[@]}") fi +# If we're doing docker, make sure we don't accidentally pollute the image with a host java path +if [ -n "${JAVA_HOME}" ]; then + unset JAVA_HOME +fi if [[ -n "${SET_JAVA_HOME}" ]]; then YETUS_ARGS=("--java-home=${SET_JAVA_HOME}" "${YETUS_ARGS[@]}") Review comment: Per earlier comments, I think we should always explicitly call `--java-home` and never leave it up to sniffing around. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services