ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324851766
########## File path: dev-support/hbase-personality.sh ########## @@ -45,6 +45,23 @@ if ! declare -f "yetus_info" >/dev/null; then fi +# work around yetus overwriting JAVA_HOME from our docker image +function docker_do_env_adds Review comment: > Without this Yetus tells docker to unset any JAVA_HOME defined in the image if the host doesn't have JAVA_HOME set, which doesn't make sense to me. This sounds like to a bug to me as well. As far as I can see, the Yetus runtime from the build host should be completely agnostic to the runtime within the docker context -- no need for setting `JAVA_HOME` any more than there's a need for, for example, a `go` executable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
