ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324265807
##########
File path: dev-support/hbase_nightly_yetus.sh
##########
@@ -40,6 +40,10 @@ if [[ -n "${MULTIJDK}" ]]; then
YETUS_ARGS=("--multijdkdirs=${MULTIJDK}" "${YETUS_ARGS[@]}")
fi
+# If we're doing docker, make sure we don't accidentally pollute the image
with a host java path
Review comment:
Does this ever not run in Docker mode? Can we settle on only running in
Docker mode? It keeps things simpler and tidy, IMHO. The possibility of host
environment values leaking in makes for bizarre bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
