ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member visibility in HRegionServer URL: https://github.com/apache/hbase/pull/775#discussion_r341363875
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ########## @@ -331,47 +328,36 @@ // Go down hard. Used if file system becomes unavailable and also in // debugging and unit tests. private volatile boolean abortRequested; - public static final String ABORT_TIMEOUT = "hbase.regionserver.abort.timeout"; + static final String ABORT_TIMEOUT = "hbase.regionserver.abort.timeout"; // Default abort timeout is 1200 seconds for safe private static final long DEFAULT_ABORT_TIMEOUT = 1200000; // Will run this task when abort timeout - public static final String ABORT_TIMEOUT_TASK = "hbase.regionserver.abort.timeout.task"; - - ConcurrentMap<String, Integer> rowlocks = new ConcurrentHashMap<>(); + static final String ABORT_TIMEOUT_TASK = "hbase.regionserver.abort.timeout.task"; // A state before we go into stopped state. At this stage we're closing user // space regions. private boolean stopping = false; - - volatile boolean killed = false; - + private volatile boolean killed = false; private volatile boolean shutDown = false; protected final Configuration conf; - private Path rootDir; + private Path dataRootDir; private Path walRootDir; - protected final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(); - - final int numRetries; - protected final int threadWakeFrequency; - protected final int msgInterval; + private final int threadWakeFrequency; + final int msgInterval; private static final String PERIOD_COMPACTION = "hbase.regionserver.compaction.check.period"; private final int compactionCheckFrequency; private static final String PERIOD_FLUSH = "hbase.regionserver.flush.check.period"; private final int flushCheckFrequency; - protected final int numRegionsToReport; - // Stub to do region server status calls against the master. private volatile RegionServerStatusService.BlockingInterface rssStub; private volatile LockService.BlockingInterface lockStub; // RPC client. Used to make the stub above that does region server status checking. - RpcClient rpcClient; - - private RpcControllerFactory rpcControllerFactory; Review comment: Another field assigned but never used. `RpcControllerFactory` instances do existing the codebase, they're just not pulled from `HRegionServer` any more. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
