ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r341296609
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1819,7 +1785,7 @@ protected void chore() {
if (r.shouldFlush(whyFlush)) {
FlushRequester requester = server.getFlushRequester();
if (requester != null) {
- long randomDelay = (long) RandomUtils.nextInt(0, rangeOfDelay) +
MIN_DELAY_TIME;
+ long randomDelay = RandomUtils.nextLong(0, rangeOfDelayMs) +
MIN_DELAY_TIME;
Review comment:
No I don't believe it will. I think `int` was used down here because the
value is read out as an `int` using `conf.getInt()` -- which it still uses. The
value will remain as whatever was read from the config. I'm simply converting
the value to a `long` slightly earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
