ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r341225386
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -549,28 +534,30 @@
* means it needs to just come up and make do without a Master to talk to:
e.g. in test or
* HRegionServer is doing other than its usual duties: e.g. as an
hollowed-out host whose only
* purpose is as a Replication-stream sink; see HBASE-18846 for more.
+ * TODO: can this replace {@link #TEST_SKIP_REPORTING_TRANSITION} ?
*/
private final boolean masterless;
- static final String MASTERLESS_CONFIG_NAME = "hbase.masterless";
+ private static final String MASTERLESS_CONFIG_NAME = "hbase.masterless";
/**regionserver codec list **/
- public static final String REGIONSERVER_CODEC = "hbase.regionserver.codecs";
+ private static final String REGIONSERVER_CODEC = "hbase.regionserver.codecs";
// A timer to shutdown the process if abort takes too long
private Timer abortMonitor;
/**
- * Starts a HRegionServer at the default location
+ * Starts a HRegionServer at the default location.
+ * <p/>
+ * Don't start any services or managers in here in the Constructor.
+ * Defer till after we register with the Master as much as possible. See
{@link #startServices}.
*/
- // Don't start any services or managers in here in the Constructor.
- // Defer till after we register with the Master as much as possible. See
#startServices.
- public HRegionServer(Configuration conf) throws IOException {
+ public HRegionServer(final Configuration conf) throws IOException {
Review comment:
`final` on params makes me feel better at night knowing we're not trying to
use "out" parameters. Overall I find that pushing toward a more functional
style leads to more reliable and maintainable code, and making as many things
final as possible makes for good general hygiene.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
