ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r341227551
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -3807,10 +3688,14 @@ public SecureBulkLoadManager
getSecureBulkLoadManager() {
}
@Override
- public EntityLock regionLock(List<RegionInfo> regionInfos, String
description, Abortable abort)
- throws IOException {
- return new LockServiceClient(conf, lockStub,
asyncClusterConnection.getNonceGenerator())
- .regionLock(regionInfos, description, abort);
+ public EntityLock regionLock(
+ final List<RegionInfo> regionInfo,
+ final String description,
+ final Abortable abort
+ ) {
Review comment:
I'm using the code formatter in `dev-support/hbase_eclipse_formatter.xml`
and checkstyle doesn't complain about it. The newlines between method arguments
make for simpler reading and shorter diffs in the long run. My rule of thumb is
that if the parameter list need to wrap, they should probably be broken out
into one line each.
What formatter do you use? It would be great if we didn't have to talk about
this at all, if there was a tool like rust or go that just does it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
