bharathv commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369984248
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##########
@@ -170,27 +171,36 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
this.masterClass = (Class<? extends HMaster>)
conf.getClass(HConstants.MASTER_IMPL, masterClass);
// Start the HMasters.
- for (int i = 0; i < noMasters; i++) {
+ int i;
+ for (i = 0; i < noMasters; i++) {
addMaster(new Configuration(conf), i);
}
-
- // Populate the master address host ports in the config. This is needed if
a master based
- // registry is configured for client metadata services (HBASE-18095)
- List<String> masterHostPorts = new ArrayList<>();
- getMasters().forEach(masterThread ->
-
masterHostPorts.add(masterThread.getMaster().getServerName().getAddress().toString()));
- conf.set(HConstants.MASTER_ADDRS_KEY, String.join(",", masterHostPorts));
-
+ for (int j = 0; j < noAlwaysStandByMasters; j++) {
+ Configuration c = new Configuration(conf);
+ c.set(HConstants.MASTER_IMPL,
"org.apache.hadoop.hbase.master.AlwaysStandByHMaster");
+ addMaster(c, i + j);
+ }
// Start the HRegionServers.
this.regionServerClass =
(Class<? extends
HRegionServer>)conf.getClass(HConstants.REGION_SERVER_IMPL,
regionServerClass);
- for (int i = 0; i < noRegionServers; i++) {
- addRegionServer(new Configuration(conf), i);
+ for (int j = 0; j < noRegionServers; j++) {
+ addRegionServer(new Configuration(conf), j);
}
}
+ /**
+ * Populates the master address host ports in the config. This is needed if
a master based
+ * registry is configured for client metadata services (HBASE-18095)
+ */
+ private void refreshMasterAddrsConfig() {
+ List<String> masterHostPorts = new ArrayList<>();
+ getMasters().forEach(masterThread ->
+
masterHostPorts.add(masterThread.getMaster().getServerName().getAddress().toString()));
+ conf.set(HConstants.MASTER_ADDRS_KEY, String.join(",", masterHostPorts));
Review comment:
Ah I rewrote this multiple times to get it working and in that process
called it from multiple places, hence separated it out into a method. Doesn't
make sense anymore like you pointed out. Moved it to the new place instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
