bharathv commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369985314
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -789,8 +789,17 @@ public boolean
registerService(com.google.protobuf.Service instance) {
return true;
}
- private Configuration unsetClientZookeeperQuorum() {
+ private Configuration cleanupConfiguration() {
Configuration conf = this.conf;
+ // We use ZKConnectionRegistry for all the internal communication,
primarily for these reasons:
+ // - Decouples RS and master life cycles. RegionServers can continue be up
independent of
+ // masters' availability.
Review comment:
Region servers abort if the connection doesn't work for any reason. With
master registry, if the master is down the registry methods throw connection
refused and that can bringdown the entire set of region servers at the same
time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
