bharathv commented on a change in pull request #1039: HBASE-23647: Make
MasterRegistry the default impl.
URL: https://github.com/apache/hbase/pull/1039#discussion_r369992690
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSideWithCoprocessor.java
##########
@@ -43,7 +43,7 @@
@Parameterized.Parameters
public static Collection parameters() {
return Arrays.asList(new Object[][] {
- { ZKConnectionRegistry.class, 1}
+ { MasterRegistry.class, 1}
Review comment:
This test is a bit special, I had to parameterize it in the first place to
override parent test params. The parent test (TestFromClientSide) has a lot of
coverage for ZKConnectionRegistry and I felt this is redundant (tests the same
thing) so removed. You prefer to retain it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
