bharathv commented on a change in pull request #934: HBASE-23568: Improve
Threading of Replication
URL: https://github.com/apache/hbase/pull/934#discussion_r376661329
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -126,10 +134,16 @@
private long defaultBandwidth;
private long currentBandwidth;
private WALFileLengthProvider walFileLengthProvider;
+
@VisibleForTesting
- protected final ConcurrentHashMap<String, ReplicationSourceShipper>
workerThreads =
+ protected final Map<String, ReplicationSourceShipper> workerThreads =
new ConcurrentHashMap<>();
+ private final ListeningExecutorService executorService =
+ MoreExecutors.listeningDecorator(Executors.newCachedThreadPool(
+ new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("replicationSource-%d")
Review comment:
I think there is some loss of debugging information here. Earlier the worker
and reader threads were annotated with walGroupId and stuff, any chance to get
that back? I think that is some useful information in jstacks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
