bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r400438158
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -287,6 +287,8 @@ message SlowLogResponseRequest {
optional string client_address = 3;
optional string user_name = 4;
optional uint32 limit = 5 [default = 10];
+ optional bool is_slow_log = 6 [default = false];
Review comment:
use an enum? OnlineLogType for ex.. Also, you don't need to have two
separate RPCs if you pass this "type" as a param to the RPC call (we can
potentially have other "types" in the future in which case we don't want to add
a new set of RPCs).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
