bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401092270
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -287,6 +287,8 @@ message SlowLogResponseRequest {
optional string client_address = 3;
optional string user_name = 4;
optional uint32 limit = 5 [default = 10];
+ optional bool is_slow_log = 6 [default = false];
Review comment:
They still have the same experience, its just what each client does with the
API. For example, there are 10 (or more) ways of creating a table from shell
but only 3 corresponding create admin APIs. All these 10 map to one of these 3
APIs. Java/Thrift clients for this API build the TableDescriptor and use one of
these 3 API calls. It is somewhat a similar case here. At least this is my
understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
