bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401079813
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -287,6 +287,8 @@ message SlowLogResponseRequest {
optional string client_address = 3;
optional string user_name = 4;
optional uint32 limit = 5 [default = 10];
+ optional bool is_slow_log = 6 [default = false];
Review comment:
> IMHO having separate shell command and Admin API should be good and clean
for operators rather than having "type" as a filter.
Umm.. shell command is fine, probably makes it easier for operators...whats
the use of having a separate Admin API? All of these requests fall under the
same "get_log" category, so probably good to logically group them into same API
(which takes Type parameter) and avoid code bloat?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
