virajjasani commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r400664422
##########
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##########
@@ -287,6 +287,8 @@ message SlowLogResponseRequest {
optional string client_address = 3;
optional string user_name = 4;
optional uint32 limit = 5 [default = 10];
+ optional bool is_slow_log = 6 [default = false];
Review comment:
IMHO having separate shell command and Admin API should be good and clean
for operators rather than having "type" as a filter. I agree on implementing
enum for "type" on server side including this proto file. We can have filter
logic at server side but having separate API for client would be better because
all filters that we want to provide to client should be related to actual data
filters - client, user, region, table etc rather than type.
Most of the time, user would not use filter so we don't want them to use
filter just for log type.
`get_slowlog_responses '*'` and `get_largelog_responses '*'` might be mostly
used (without filters).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
