[
https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214500#comment-17214500
]
Duo Zhang commented on HBASE-25183:
-----------------------------------
{quote}
Your favorite question... is there a write-up for this intent anywhere? ('my
plan') So far we have a JIRA with no description. What is the scope, when is
the deliverable for? Why we doing this?
{quote}
This is the description of HBASE-23933
{noformat}
Open an issue here. After we merge hbase-rsgroup back to hbase-server, the
hbase-server even makes findbugs OOM...
So I think we should try to move out classes to make the module smaller...
{noformat}
I do not think this is 'a JIRA with no description'. It clearly describe what
we want to do and the motivation.
And on the PR, I've replied
{quote}
I think this is a good start.
A possible direction is to abstract some interfaces for retrieving servers and
regions from master, so we can move more classes to hbase-balancer module.
{quote}
My above comment is just more detailed explaination of the this comment on PR,
where I want to answer your question more clearly. And since you mentioned
stochastic balancer, I checked the code of stochastic balancer this morning,
and replied here what I found.
I think I've already tried my best to show my friendness and respect here. But
I do not think I got enough respect back. If this continues in the future, I
will draft an email to board directly to seek for help.
And I will not respond to other questions, as you just did not read the history
of all the issues and PRs before posting aggressive comment on the jira. Please
show your respect to all the developers involved here. At least, [~ndimiduk]
also replied on that jira to say that this is good and he was also trying to
help moving out other classes, and the PR was opened by [~niuyulin], and the PR
had also been approved by [~vjasani]. It is not only me OK?
And on the last part.
{quote}
Generally I think the pickings around balancer are lean. Just leave it w/
intimate access to Master. Lets pick on something meatier that will make for
more yield like Region?
{quote}
I agree with you that balancer is not as big as the HRegion related code. But I
think we also need to agree that, it is much more difficult to move the HRegion
related code out right? At least I'm not in favor of doing it for now. If you
want to do I will not stop you. And as I said above, moving balancer is
possible for now, if you do not like it you can just leave it and do other
things as we have lots of TODOs in HBase. We have enough committers to review
code here, you do not need to take care of everything.
Thanks.
> Move more balancer related classes to hbase-balancer
> ----------------------------------------------------
>
> Key: HBASE-25183
> URL: https://issues.apache.org/jira/browse/HBASE-25183
> Project: HBase
> Issue Type: Umbrella
> Components: Balancer
> Reporter: Duo Zhang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
