[ 
https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215084#comment-17215084
 ] 

Duo Zhang commented on HBASE-25183:
-----------------------------------

And what your next reply is the actual ‘reasonable’ comment. I usually get this 
style of reply from you or Sean, which is helpful as it has strict action 
suggestion, and I will happy to do the write up and also explain the concern. 
But think of that someone always ask ‘questions’ like rhetorical question? It 
is not a question, it’s just blaming.

On a mobile device so not easy to construct the reply. We have a ClusterMetrics 
and usually we will use the metrics there to do calculation. I think this is 
also a very good abstraction. All the developers of the balancer module except 
the FN balancer are all good at abstraction and tried best to not rely on 
master too much. I think this could be kept in the future. So in general, I do 
not think we need to modify two places, just add new metrics to ClusterMetrics 
and balancer could benefit.

Thanks.

> Move more balancer related classes to hbase-balancer
> ----------------------------------------------------
>
>                 Key: HBASE-25183
>                 URL: https://issues.apache.org/jira/browse/HBASE-25183
>             Project: HBase
>          Issue Type: Umbrella
>          Components: Balancer
>            Reporter: Duo Zhang
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to