[GitHub] [hbase] apurtell commented on a change in pull request #2681: HBASE-25308 [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

[GitBox]

apurtell commented on a change in pull request #2681:
URL: https://github.com/apache/hbase/pull/2681#discussion_r527929047



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -270,7 +269,8 @@ private void uninitialize() {
     metrics.clear();
     if (replicationEndpoint.state() == Service.State.STARTING
         || replicationEndpoint.state() == Service.State.RUNNING) {
-      replicationEndpoint.stopAndWait();
+      replicationEndpoint.stopAsync();

Review comment:
       This unit contains several changes required by evolution in Guava's 
Service interface. Our ReplicationEndpoint extends this interface. stopAndWait 
is replaced with stopAsync() and awaitTerminated()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org