Apache9 commented on a change in pull request #2814:
URL: https://github.com/apache/hbase/pull/2814#discussion_r548889401
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
##########
@@ -36,13 +36,13 @@
*/
@InterfaceAudience.Private
public class MultiVersionConcurrencyControl {
- private static final Logger LOG =
LoggerFactory.getLogger(MultiVersionConcurrencyControl.class);
private static final long READPOINT_ADVANCE_WAIT_TIME = 10L;
final String regionName;
final AtomicLong readPoint = new AtomicLong(0);
final AtomicLong writePoint = new AtomicLong(0);
- private final Object readWaiters = new Object();
+
+ private final ThreadLocal<WriteEntry> cachedWriteEntries;
Review comment:
Is it always safe to use ThreadLocal here? What if users just use
ASYNC_WAL or even NO_WAL and return without waiting for MVCC to move？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
