nyl3532016 commented on a change in pull request #2814:
URL: https://github.com/apache/hbase/pull/2814#discussion_r549587198



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
##########
@@ -272,33 +252,59 @@ public long getWritePoint() {
    */
   @InterfaceAudience.Private
   public static class WriteEntry {
-    private final long writeNumber;
+    private long writeNumber = 0L;
     private boolean completed = false;
+    private static final Logger LOG = 
LoggerFactory.getLogger(WriteEntry.class);
 
-    WriteEntry(long writeNumber) {
-      this.writeNumber = writeNumber;
+    synchronized WriteEntry markCompleted(boolean completed) {

Review comment:
       when reuse the thread local `WriteEntry`, we must set it incomplete




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to