nyl3532016 commented on pull request #2814: URL: https://github.com/apache/hbase/pull/2814#issuecomment-751971855
> Have to be careful changing this code. It is hard to get it right. > > The narrow notify in place of the notifyAll is nice but I see lots of new synchronize blocks in this PR when we check for state change; do these new synchronizes undo the advantage of the notify on WriteEntry only? Can you demonstrate improved throughput? Let me test via ycsb to see wether it can improve throughput. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
