nyl3532016 commented on a change in pull request #2814:
URL: https://github.com/apache/hbase/pull/2814#discussion_r549242127
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2754,10 +2754,10 @@ protected PrepareFlushResult
internalPrepareFlushCache(WAL wal, long myseqid,
if (wal != null) {
writeEntry = mvcc.begin();
long flushOpSeqId = writeEntry.getWriteNumber();
+ mvcc.completeAndWait(writeEntry);
FlushResultImpl flushResult =
new
FlushResultImpl(FlushResult.Result.CANNOT_FLUSH_MEMSTORE_EMPTY, flushOpSeqId,
"Nothing to flush", writeFlushRequestMarkerToWAL(wal,
writeFlushWalMarker));
- mvcc.completeAndWait(writeEntry);
Review comment:
if `writeEntry` be threadLocal, the logic here is wrong.
`writeFlushRequestMarkerToWAL` contains mvcc begin and complete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
