saintstack commented on a change in pull request #2814:
URL: https://github.com/apache/hbase/pull/2814#discussion_r550912921
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
##########
@@ -185,7 +191,7 @@ public void completeAndWait(WriteEntry e) {
*/
public boolean complete(WriteEntry writeEntry) {
synchronized (writeQueue) {
- writeEntry.markCompleted();
+ writeEntry.markCompleted(true);
Review comment:
Do we ever pass false? I don't see it (perhaps we do). If we don't, then
markCompleted seems fine (without a param). setCompleted makes sense if a param
is passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
