Apache9 commented on a change in pull request #3150:
URL: https://github.com/apache/hbase/pull/3150#discussion_r617144670



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -110,6 +111,15 @@ public SplitTableRegionProcedure(final MasterProcedureEnv 
env,
     // we fail-fast on construction. There it skips the split with just a 
warning.
     checkOnline(env, regionToSplit);
     this.bestSplitRow = splitRow;
+    TableDescriptor tableDescriptor = 
env.getMasterServices().getTableDescriptors()
+      .get(getTableName());
+    Configuration conf = env.getMasterConfiguration();
+    if (hasBestSplitRow()) {

Review comment:
       But what if we do not provide a split point when constructing the 
SplitTableRegionProcedure? How do we get the split point?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to