brfrn169 commented on a change in pull request #3150:
URL: https://github.com/apache/hbase/pull/3150#discussion_r617155097
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -110,6 +111,15 @@ public SplitTableRegionProcedure(final MasterProcedureEnv
env,
// we fail-fast on construction. There it skips the split with just a
warning.
checkOnline(env, regionToSplit);
this.bestSplitRow = splitRow;
+ TableDescriptor tableDescriptor =
env.getMasterServices().getTableDescriptors()
+ .get(getTableName());
+ Configuration conf = env.getMasterConfiguration();
+ if (hasBestSplitRow()) {
Review comment:
In that case, `hasBestSplitRow()` returns `false` and
SplitTableRegionProcedure will try to find a best split key from RS as follows:
https://github.com/apache/hbase/blob/781da1899aad7a50ce9c096be757cc1cab3dc15e/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java#L193-L199
In this change, we apply a split restriction only when a user specifies a
split point (and `hasBestSplitRow()` returns `true`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
