Apache9 commented on a change in pull request #3150:
URL: https://github.com/apache/hbase/pull/3150#discussion_r617157431
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -110,6 +111,15 @@ public SplitTableRegionProcedure(final MasterProcedureEnv
env,
// we fail-fast on construction. There it skips the split with just a
warning.
checkOnline(env, regionToSplit);
this.bestSplitRow = splitRow;
+ TableDescriptor tableDescriptor =
env.getMasterServices().getTableDescriptors()
+ .get(getTableName());
+ Configuration conf = env.getMasterConfiguration();
+ if (hasBestSplitRow()) {
Review comment:
OK, so this should be a behavior change. In the past if user specify a
split point, we will always use it no matter whether it breaks the split point
restriction and now we will try to convert it. Is the old behavior a bug or a
feature? For me I do not think we should let user to break the restriction.
@saintstack WDYT sir?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
