wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r663822974
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1167,7 +1170,7 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
} else {
final boolean shouldCacheDataOnWrite =
cacheConf.shouldCacheDataOnWrite();
if (shouldCacheDataOnWrite) {
- writerCacheConf.enableCacheOnWrite();
+ writerCacheConf.enableCacheOnWriteForCompactions();
Review comment:
Yeah, should be only `enableCacheOnWrite`, as here we are calling it for
other writes than compactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
