wchevreuil commented on a change in pull request #3389:
URL: https://github.com/apache/hbase/pull/3389#discussion_r663947613
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -694,7 +700,7 @@ private void
refreshStoreFilesInternal(Collection<StoreFileInfo> newFiles) throw
refreshStoreSizeAndTotalBytes();
}
- protected HStoreFile createStoreFileAndReader(final Path p) throws
IOException {
+ public HStoreFile createStoreFileAndReader(final Path p) throws IOException {
Review comment:
Prior tho this, the "commit compaction" logic was implemented straight
inside `HStore.doCompaction -> moveCompactedFilesIntoPlace ->
moveFileIntoPlace` which was where `createStoreFileAndReader` was getting
called. I believe this is "compaction specific" logic, and if we are aiming for
pluggable compaction behaviour, it shouldn't be implemented in the HStore.
That's why here we changed it to be `HStore.doCompaction ->
storeEngine.compactor.commitCompaction`, so we had to eventually call it from
the compactors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
