bharathv commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r685432351
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
*/
private static final long
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
- /*
+ /**
* Whether to reject rows with size > threshold defined by
* {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
*/
private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
"hbase.rpc.rows.size.threshold.reject";
- /*
+ /**
* Default value of config {@link
RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
*/
private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD =
false;
+ /**
+ * Determine the bootstrap nodes we want to return to the client connection
registry.
+ * <ul>
+ * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>
Review comment:
Sorry for the delay boss, I was busy last few days.
My only concern here is that it is against the agreed design principle of
not putting masters inline with the connection path and exposing such a
configuration might complicate things going forward as future developers might
build on top of it.
Typically for small clusters, since it is impossible to run a meaningful
cluster without a region server, but things can run for sometime without a
master, so we can expect that at least one region server to up all the time if
it is serving any load. So a registry can be served with that region server(s)?
WDYT?
@saintstack / @francisliu you have any comments on this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
