Apache9 commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r688283296
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
*/
private static final long
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
- /*
+ /**
* Whether to reject rows with size > threshold defined by
* {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
*/
private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
"hbase.rpc.rows.size.threshold.reject";
- /*
+ /**
* Default value of config {@link
RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
*/
private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD =
false;
+ /**
+ * Determine the bootstrap nodes we want to return to the client connection
registry.
+ * <ul>
+ * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>
Review comment:
> It appeared that you intended to keep both MasterRegistry,
RpcConnectionRegistry with masters.
Let me explain more...
The issue here, aims to remove MasterRegistry in the future, so
1. Ideally RpcConnectionRegistry should cover what we have in
MasterRegistry, by some configurations at least.
2. We just do not want to support masters any more, so we do not need to
provide configurations at server side, after MasterRegistry is removed, users
can not use masters as connection registry endpoint any more.
But if we go with option 2, maybe it breaks some users, so maybe we should
keep MasterRegistry and do not mark it as deprecated? And then, the
RpcConnectionRegistry should better be renamed to RegionServerRegistry.
So let me conclude, there are 3 options:
1. Deprecated MasterRegistry, plan a removal in 4.0.0, and let
RpcConnectionRegistry still provide the ability to use masters as connection
registry endpoint.
2. Deprecated MasterRegistry, plan a removal in 4.0.0, but still keep
RpcConnectionRegistry only use region servers as connection registry endpoint.
3. Do not deprecated MasterRegistry, rename RpcConnectionRegistry to
RegionServerRegistry.
I do not think we need to rename RpcConnectionRegistry to
RegionServerRegistry if we still want to remove MasterRegistry, so there is
option 4.
Please let me know your choice. But if you want to choose 2 or 3, I think
we'd better post a discussion email to the dev list, as it removes a feature
currently in use, we need to collect more information from users.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
