Apache9 commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r686445274
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
*/
private static final long
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
- /*
+ /**
* Whether to reject rows with size > threshold defined by
* {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
*/
private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
"hbase.rpc.rows.size.threshold.reject";
- /*
+ /**
* Default value of config {@link
RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
*/
private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD =
false;
+ /**
+ * Determine the bootstrap nodes we want to return to the client connection
registry.
+ * <ul>
+ * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>
Review comment:
I'm fine with removing this but then we can not deprecated
MasterRegistry? Or we just tell users you can not use masters as registry any
more? Since the MasterRegistry has already been released out, and people are
currently using it, I'm not sure whether this is a good idea...
For me I prefer we set the default value to only use region servers, but if
users do want to use masters, they could change the config as they like,
especially that the implementation itself does not introduce much complexity.
So let's make a decision here? Let's move forward.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
