saintstack commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r686308948
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java
##########
@@ -49,7 +49,7 @@
public class RpcConnectionRegistry extends AbstractRpcBasedConnectionRegistry {
/** Configuration key that controls the fan out of requests **/
- public static final String HEDGED_REQS_FANOUT_KEY =
"hbase.client.rpc_registry.hedged.fanout";
+ public static final String HEDGED_REQS_FANOUT_KEY =
"hbase.client.bootstrap.hedged.fanout";
Review comment:
hbase.client.rpc_registry.hedged.fanout is a new config recently added.
It is committed to a branch only currently? So it is fine changing the name?
Does the config get doc'd in release notes?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
*/
private static final long
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
- /*
+ /**
* Whether to reject rows with size > threshold defined by
* {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
*/
private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
"hbase.rpc.rows.size.threshold.reject";
- /*
+ /**
* Default value of config {@link
RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
*/
private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD =
false;
+ /**
+ * Determine the bootstrap nodes we want to return to the client connection
registry.
+ * <ul>
+ * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>
Review comment:
Looking more, appreciate offering the option but like the @bharathv
comment that we should just do RS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
