bharathv commented on a change in pull request #3566:
URL: https://github.com/apache/hbase/pull/3566#discussion_r688816428
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -308,18 +310,35 @@
*/
private static final long
DEFAULT_REGION_SERVER_RPC_MINIMUM_SCAN_TIME_LIMIT_DELTA = 10;
- /*
+ /**
* Whether to reject rows with size > threshold defined by
* {@link RSRpcServices#BATCH_ROWS_THRESHOLD_NAME}
*/
private static final String REJECT_BATCH_ROWS_OVER_THRESHOLD =
"hbase.rpc.rows.size.threshold.reject";
- /*
+ /**
* Default value of config {@link
RSRpcServices#REJECT_BATCH_ROWS_OVER_THRESHOLD}
*/
private static final boolean DEFAULT_REJECT_BATCH_ROWS_OVER_THRESHOLD =
false;
+ /**
+ * Determine the bootstrap nodes we want to return to the client connection
registry.
+ * <ul>
+ * <li>{@link #MASTER}: return masters as bootstrap nodes.</li>
Review comment:
What I'm saying in my above comment is "deprecate MasterRegistry and
rename RpcConnectionRegistry" (similar to option 2) and _everything still works
as expected for current MasterRegistry users_. Details in
https://github.com/apache/hbase/pull/3566#discussion_r687025151
If we go with option 2, can you explain me what does not work for current
users of MasterRegistry? If you explain how it is broken, I'm +1 on option (1).
(see my last comment as to why I think it is not broken, may be I misunderstood
something) https://github.com/apache/hbase/pull/3566#discussion_r687025151
Only broken case I can think of is old client binary is not compatible with
new Server binary, but that is not a problem we are worried about? Is there any
other case too?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
