BukrosSzabolcs commented on a change in pull request #3751:
URL: https://github.com/apache/hbase/pull/3751#discussion_r732525043
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
##########
@@ -63,22 +63,30 @@ public StoreFileWriter createWriter(InternalScanner scanner,
}
@Override
- protected List<Path> commitWriter(StoreFileWriter writer, FileDetails fd,
+ protected List<Path> commitWriter(FileDetails fd,
CompactionRequestImpl request) throws IOException {
List<Path> newFiles = Lists.newArrayList(writer.getPath());
writer.appendMetadata(fd.maxSeqId, request.isAllFiles(),
request.getFiles());
writer.close();
+ writer = null;
Review comment:
writer was refactored to be a class variable so I can list current
compaction targets any time and can avoid deleting them. So the variable is
re-used and have to be cleaned up after a compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
