Apache9 commented on a change in pull request #3751:
URL: https://github.com/apache/hbase/pull/3751#discussion_r733582037
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMultiFileWriter.java
##########
@@ -110,7 +110,7 @@ public void init(StoreScanner sourceScanner, WriterFactory
factory) {
return paths;
}
- protected abstract Collection<StoreFileWriter> writers();
+ public abstract Collection<StoreFileWriter> writers();
Review comment:
So what you want to avoid here is for a long running compaction, the
modification time of the file is already long ago but it is still being
written, so if we only use timestamp to determine whether it is OK to delete it
we may delete it incorrectly?
This is a possible problem, but it still makes me a bit nervous that, we do
not have any fencing here, so it is still possible that we hit some corner
cases where we will delete these files?
Please give me some time to think of this...
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
