[ 
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17546691#comment-17546691
 ] 

Hudson commented on HBASE-27046:
--------------------------------

Results for branch branch-2.5
        [build #133 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/]:
 (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The filenum in AbstractFSWAL should be monotone increasing
> ----------------------------------------------------------
>
>                 Key: HBASE-27046
>                 URL: https://issues.apache.org/jira/browse/HBASE-27046
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> This is the current code
> {code}
>   /**
>    * retrieve the next path to use for writing. Increments the internal 
> filenum.
>    */
>   private Path getNewPath() throws IOException {
>     this.filenum.set(EnvironmentEdgeManager.currentTime());
>     Path newPath = getCurrentFileName();
>     while (fs.exists(newPath)) {
>       this.filenum.incrementAndGet();
>       newPath = getCurrentFileName();
>     }
>     return newPath;
>   }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts 
> always or even go backwards, the logic here is not rnough to keep the filenum 
> monotone increasing, as we may have already archive the old file.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to