[
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552150#comment-17552150
]
Duo Zhang commented on HBASE-27046:
-----------------------------------
Looked at the flaky dashboard, TestQuotaThrottle has been included in the flaky
list so it will not fail the pre commit job now.
https://ci-hbase.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/output/excludes/*view*/
> The filenum in AbstractFSWAL should be monotone increasing
> ----------------------------------------------------------
>
> Key: HBASE-27046
> URL: https://issues.apache.org/jira/browse/HBASE-27046
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> This is the current code
> {code}
> /**
> * retrieve the next path to use for writing. Increments the internal
> filenum.
> */
> private Path getNewPath() throws IOException {
> this.filenum.set(EnvironmentEdgeManager.currentTime());
> Path newPath = getCurrentFileName();
> while (fs.exists(newPath)) {
> this.filenum.incrementAndGet();
> newPath = getCurrentFileName();
> }
> return newPath;
> }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts
> always or even go backwards, the logic here is not rnough to keep the filenum
> monotone increasing, as we may have already archive the old file.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
