[
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552117#comment-17552117
]
Nick Dimiduk commented on HBASE-27046:
--------------------------------------
Heya [~zhangduo], the patch for this change enabled TestQuotaThrottle, which is
again failing quite reliably. It actually enabled two tests, neither of which
are clearly related to the stated change in this issue's title. Any comments
here? I think we should re-disable TestQuotaThrottle, if not both of them.
Thanks.
> The filenum in AbstractFSWAL should be monotone increasing
> ----------------------------------------------------------
>
> Key: HBASE-27046
> URL: https://issues.apache.org/jira/browse/HBASE-27046
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
>
> This is the current code
> {code}
> /**
> * retrieve the next path to use for writing. Increments the internal
> filenum.
> */
> private Path getNewPath() throws IOException {
> this.filenum.set(EnvironmentEdgeManager.currentTime());
> Path newPath = getCurrentFileName();
> while (fs.exists(newPath)) {
> this.filenum.incrementAndGet();
> newPath = getCurrentFileName();
> }
> return newPath;
> }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts
> always or even go backwards, the logic here is not rnough to keep the filenum
> monotone increasing, as we may have already archive the old file.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
