[
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552179#comment-17552179
]
Nick Dimiduk commented on HBASE-27046:
--------------------------------------
Okay, I now understand that this was an intentional change -- good. I agree
that we should avoid the {{@Ignore}} annotation if we can avoid it.
In the specific case of TestQuotaThrottle, during my local runs while
attempting to bisect to the introduction of the failure, I noticed that this
test is not killed properly by the HBaseClassTestRule. I think that maybe
there's a bug in there where throttling is not marking a thread as a deamon,
but I have not investigated it in depth.
Thanks!
> The filenum in AbstractFSWAL should be monotone increasing
> ----------------------------------------------------------
>
> Key: HBASE-27046
> URL: https://issues.apache.org/jira/browse/HBASE-27046
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> This is the current code
> {code}
> /**
> * retrieve the next path to use for writing. Increments the internal
> filenum.
> */
> private Path getNewPath() throws IOException {
> this.filenum.set(EnvironmentEdgeManager.currentTime());
> Path newPath = getCurrentFileName();
> while (fs.exists(newPath)) {
> this.filenum.incrementAndGet();
> newPath = getCurrentFileName();
> }
> return newPath;
> }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts
> always or even go backwards, the logic here is not rnough to keep the filenum
> monotone increasing, as we may have already archive the old file.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
