virajjasani commented on code in PR #4592:
URL: https://github.com/apache/hbase/pull/4592#discussion_r912403859
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/RefCnt.java:
##########
@@ -31,7 +34,10 @@
@InterfaceAudience.Private
public class RefCnt extends AbstractReferenceCounted {
- private Recycler recycler = ByteBuffAllocator.NONE;
+ private static final ResourceLeakDetector<RefCnt> detector =
Review Comment:
> I think Andrew's comment here was asking if we should copy the source code
of ResourceLeakDetector into the hbase repo, to avoid having upstream changes
break the leak detection for us. But I could be wrong.
Ah, I see.
> Personally I don't think it's worth copying it in -- Looks like it's been
around in netty for years and has been mostly stable, there was one minor
improvement to it recently. I'd rather only copy it in if we have a reason to,
like if we notice that they break it for us in later release. Maybe that's too
reactionary though.
Fair enough.
> I wrote up that issue before Andrew asked to add here. I'm happy to just
close that issue if this lands here. Looks like this can land here easily, so
will just close that one once this PR is merged.
+1 for landing this change here.
> I could wrap it in a special
`hbase.server.allocator.leakDetection.enabled` config
If this lands here, you would also like to consider this one right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
