bbeaudreault commented on code in PR #4592:
URL: https://github.com/apache/hbase/pull/4592#discussion_r912404097
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/RefCnt.java:
##########
@@ -31,7 +34,10 @@
@InterfaceAudience.Private
public class RefCnt extends AbstractReferenceCounted {
- private Recycler recycler = ByteBuffAllocator.NONE;
+ private static final ResourceLeakDetector<RefCnt> detector =
Review Comment:
Yea, though I wonder if it makes sense to leave as-is since it will be
confusing to have 2 configs for the same feature. To Andrew's point above, this
is already controlled via
`-Dorg.apache.hbase.thirdparty.io.netty.leakDetection.level` (which also
control's netty's own leak detection).
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
