Apache9 commented on code in PR #4924: URL: https://github.com/apache/hbase/pull/4924#discussion_r1046571171
########## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java: ########## @@ -265,6 +266,11 @@ public void replicateEntries(List<WALEntry> entries, final CellScanner cells, mutation.setClusterIds(clusterIds); mutation.setAttribute(ReplicationUtils.REPLICATION_ATTR_NAME, HConstants.EMPTY_BYTE_ARRAY); + if (attributeList != null) { Review Comment: This is WAL extended attribute, not mutation attribute? I do not think we should just set them as attributes here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org