virajjasani commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1046586266
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##########
@@ -265,6 +266,11 @@ public void replicateEntries(List<WALEntry> entries, final
CellScanner cells,
mutation.setClusterIds(clusterIds);
mutation.setAttribute(ReplicationUtils.REPLICATION_ATTR_NAME,
HConstants.EMPTY_BYTE_ARRAY);
+ if (attributeList != null) {
Review Comment:
There has to be a consumer of WAL extended attribute. The primary purpose
for anything associated with WALKey is meant for deriving appropriate Mutation
behavior or replication related behavior (like list of cluster ids). Hence if
we allow coproc to set the WAL extended attributes, we should also let the
attributes be consumed at sink side. Otherwise we won't be able to have any
consumer of these attributes, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
